Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31626 )
Change subject: google_chromeec_command: makes the error status consistent ......................................................................
Patch Set 1:
I'm okay with changing all the return codes to -1, but I'm not so sure about changing all the checks to only check for <0. As long as we don't have any valid responses >0, why not keep the old checks just to be safe? It makes for shorter code, too.
(Note that there is plenty of other precedent for using 1 instead of -1 as error returns in coreboot, e.g. plenty of platform_i2c_transfer() implementations. I'm worried that one of those might still have a chance to slip through into the EC code in some odd edge case we're overlooking.)