Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69513 )
Change subject: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented ......................................................................
{ec/superio}/acpi: Remove _PRS if no _SRS is implemented
_PRS only makes sense if _SRS is implemented.
Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/ec/google/wilco/acpi/superio.asl M src/ec/quanta/ene_kb3940q/acpi/superio.asl M src/ec/quanta/it8518/acpi/superio.asl M src/superio/ite/it8772f/acpi/superio.asl M src/superio/smsc/sio1007/acpi/superio.asl 5 files changed, 12 insertions(+), 130 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/69513/1
diff --git a/src/ec/google/wilco/acpi/superio.asl b/src/ec/google/wilco/acpi/superio.asl index b2737c3..3cec006 100644 --- a/src/ec/google/wilco/acpi/superio.asl +++ b/src/ec/google/wilco/acpi/superio.asl @@ -26,15 +26,6 @@ IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) - IRQNoFlags () {4} - } - EndDependentFn () - }) } }
@@ -61,16 +52,6 @@ IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQ (Edge, ActiveHigh, Exclusive) {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQ (Edge, ActiveHigh, Exclusive) {1} - } - EndDependentFn () - }) }
Device (PS2M) @@ -91,13 +72,5 @@ { IRQ (Edge, ActiveHigh, Exclusive) {12} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IRQ (Edge, ActiveHigh, Exclusive) {12} - } - EndDependentFn () - }) } } diff --git a/src/ec/quanta/ene_kb3940q/acpi/superio.asl b/src/ec/quanta/ene_kb3940q/acpi/superio.asl index 008f573f..b5962f0 100644 --- a/src/ec/quanta/ene_kb3940q/acpi/superio.asl +++ b/src/ec/quanta/ene_kb3940q/acpi/superio.asl @@ -24,16 +24,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {1} - } - EndDependentFn () - }) } #endif } diff --git a/src/ec/quanta/it8518/acpi/superio.asl b/src/ec/quanta/it8518/acpi/superio.asl index 9cdf265..b91324d 100644 --- a/src/ec/quanta/it8518/acpi/superio.asl +++ b/src/ec/quanta/it8518/acpi/superio.asl @@ -25,17 +25,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) - { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {1} - } - EndDependentFn () - }) } #endif
@@ -55,17 +44,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {12} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) - { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {12} - } - EndDependentFn () - }) } #endif
diff --git a/src/superio/ite/it8772f/acpi/superio.asl b/src/superio/ite/it8772f/acpi/superio.asl index 5132df0..963ec32 100644 --- a/src/superio/ite/it8772f/acpi/superio.asl +++ b/src/superio/ite/it8772f/acpi/superio.asl @@ -151,12 +151,6 @@ IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) - IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) - }) } #endif
@@ -175,11 +169,6 @@ IRQNoFlags () {4} })
- Name (_PRS, ResourceTemplate () - { - IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) - IRQNoFlags () {4} - }) } #endif
@@ -200,12 +189,6 @@ IRQNoFlags () {1} })
- Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif
@@ -223,10 +206,6 @@ IRQNoFlags () {12} })
- Name (_PRS, ResourceTemplate() - { - IRQNoFlags () {12} - }) } #endif
@@ -247,13 +226,6 @@ DMA (Compatibility, NotBusMaster, Transfer8) {2} })
- Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) } #endif
@@ -272,11 +244,6 @@ IRQNoFlags () { SIO_INFR_IRQ } })
- Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) - IRQNoFlags () { SIO_INFR_IRQ } - }) } #endif } diff --git a/src/superio/smsc/sio1007/acpi/superio.asl b/src/superio/smsc/sio1007/acpi/superio.asl index 5132df0..385a121 100644 --- a/src/superio/smsc/sio1007/acpi/superio.asl +++ b/src/superio/smsc/sio1007/acpi/superio.asl @@ -151,12 +151,6 @@ IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) - IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) - }) } #endif
@@ -174,12 +168,6 @@ IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) - IRQNoFlags () {4} - }) } #endif
@@ -199,13 +187,6 @@ IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif
@@ -222,11 +203,6 @@ { IRQNoFlags () {12} }) - - Name (_PRS, ResourceTemplate() - { - IRQNoFlags () {12} - }) } #endif
@@ -246,14 +222,6 @@ IRQNoFlags () {6} DMA (Compatibility, NotBusMaster, Transfer8) {2} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) } #endif
@@ -271,12 +239,6 @@ IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) IRQNoFlags () { SIO_INFR_IRQ } }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) - IRQNoFlags () { SIO_INFR_IRQ } - }) } #endif }