Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38476 )
Change subject: drivers/usb: Fix SSDT table to use _STR instead of _DDN
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38476/2/src/drivers/usb/acpi/usb_ac...
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/38476/2/src/drivers/usb/acpi/usb_ac...
PS2, Line 48: acpigen_write_name_string("_STR
You must use acpigen_write_name_unicode as _STR is not ASCII
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5ee2ea73cea702bd5ba26a2ee8949e4b117fbfa
Gerrit-Change-Number: 38476
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jan 2020 17:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment