Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27173 )
Change subject: drivers/i2c: Add a driver for Semtech SX9310 ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h File src/drivers/i2c/sx9310/chip.h:
https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h@19 PS1, Line 19: #include <drivers/i2c/generic/chip.h> Why is this included here?
https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h@21 PS1, Line 21: #define I2C_SX9310_ACPI_ID "SX9310" : #define I2C_SX9310_ACPI_NAME "Semtech SX9310" Can these be moved to sx9310.c?
https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/registers.h File src/drivers/i2c/sx9310/registers.h:
https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/registers.h@1... PS1, Line 17: REGISTER(TYPE, NAME) REGISTER(NAME)
https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/sx9310.c File src/drivers/i2c/sx9310/sx9310.c:
https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/sx9310.c@72 PS1, Line 72: {0} Not required.