build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36012 )
Change subject: [WIP] drivers/usb/xhci-dbc: Add USB3 Dbc ......................................................................
Patch Set 29:
(6 comments)
https://review.coreboot.org/c/coreboot/+/36012/29/src/drivers/usb/xhci-dbc.c File src/drivers/usb/xhci-dbc.c:
https://review.coreboot.org/c/coreboot/+/36012/29/src/drivers/usb/xhci-dbc.c... PS29, Line 209: xdbc_put_utf16(s_desc->wData, XDBC_STRING_MANUFACTURER, strlen(XDBC_STRING_MANUFACTURER)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/36012/29/src/drivers/usb/xhci-dbc.c... PS29, Line 235: ep_out->ep_info2 = cpu_to_le32(EP_TYPE(BULK_OUT_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/36012/29/src/drivers/usb/xhci-dbc.c... PS29, Line 242: ep_in->ep_info2 = cpu_to_le32(EP_TYPE(BULK_IN_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/36012/29/src/drivers/usb/xhci-dbc.c... PS29, Line 350: ret = handshake(&xdbc.xdbc_reg->portsc, PORTSC_CONN_STATUS, PORTSC_CONN_STATUS, 5000000, 100); line over 96 characters
https://review.coreboot.org/c/coreboot/+/36012/29/src/drivers/usb/xhci.h File src/drivers/usb/xhci.h:
https://review.coreboot.org/c/coreboot/+/36012/29/src/drivers/usb/xhci.h@13 PS29, Line 13: #define rmb() memory barrier without comment
https://review.coreboot.org/c/coreboot/+/36012/29/src/drivers/usb/xhci.h@17 PS29, Line 17: #define wmb() memory barrier without comment