Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48642 )
Change subject: zork: update gumboz variant
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48642/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/gumboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/48642/2/src/mainboard/google/zork/v...
PS2, Line 17: K4AAG165WA-BCWE, 10
You should not be assigning fixed IDs, please allow the tool to auto assign IDs.
hi Rob,
it's because gumboz uses the same DRAM table as dirinboz so the DRAM index should be fixed I suppose. thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80c03d531761c02b68bd127d889c3ace2dd9e99e
Gerrit-Change-Number: 48642
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Dec 2020 15:15:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment