Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38620 )
Change subject: mb/google/volteer: add volteer mainboard initial support ......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38620/16/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/38620/16/src/mainboard/google/volte... PS16, Line 121: PAD_CFG_GPI_SCI_LOW This is not correct. It should be PAD_CFG_GPI_APIC
https://review.coreboot.org/c/coreboot/+/38620/16/src/mainboard/google/volte... PS16, Line 233: PAD_CFG_GPO PAD_CFG_GPO takes in only 3 params.