Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39130 )
Change subject: vendorcode/intel/fsp: Add Jasper Lake FSP headers for FSP v2052
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39130/6/src/vendorcode/intel/fsp/fs...
File src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/39130/6/src/vendorcode/intel/fsp/fs...
PS6, Line 653: FSPS_UPD;
we will raise a bug to make both header same.
Thanks for clarification. The header generated after building FSP matches with the header here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb911418a6f8fe573b8d097b519c433e8ea6bd73
Gerrit-Change-Number: 39130
Gerrit-PatchSet: 6
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Feb 2020 07:12:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-MessageType: comment