[coreboot-gerrit] [M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email )

Change subject: lib: Refactor ux_locales_get_text API
......................................................................

Patch Set 12:

(4 comments)

File src/include/ux_locales.h:

https://review.coreboot.org/c/coreboot/+/86283/comment/e2414dff_29fe8f65?usp... :
PS12, Line 22:  * Otherwise NULL (for unit-tests).
> No longer applicable

Acknowledged

File src/lib/ux_locales.c:

https://review.coreboot.org/c/coreboot/+/86283/comment/00a87563_bcf767b3?usp... :
PS12, Line 207: const char *ux_locales_get_text(enum ux_locale_msg msg_id)
> nit: not really clear why this part is an extra function rather than inlined into the other one?

Acknowledged

File tests/lib/ux_locales-test.c:

https://review.coreboot.org/c/coreboot/+/86283/comment/d5f4add4_8e2fe03b?usp... :
PS12, Line 213: 			 "Please do not turn off your device_0"),
> There should also be at least one test that successfully finds a lang_id which is not 0 (because 0 i […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/86283/comment/d2794d70_621b92bb?usp... :
PS12, Line 215: 7
> Maybe make this a `3`, then you also include the "check the whole string of lang_id" part here (beca […]

Acknowledged