Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262 ) Change subject: util: cbfstool: Check alignment at build time ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/c/coreboot/+/37262/11/Documentation/lib/flashmap... File Documentation/lib/flashmap.md: https://review.coreboot.org/c/coreboot/+/37262/11/Documentation/lib/flashmap... PS11, Line 114: must be aligned to erase block (e.g., 4k).
This tests both offset and size alignment, maybe we should make the documentation more explicit abou […] To tie this to true erase block sizes, we could factor out the erase size definitions from src/drivers/spi/$vendor.c so cbfstool can link them in, and pass the Kconfig flags that say which of these drivers to use into cbfstool as well: that way it could verify against real world data at compile time.
Could (and should) be a follow-up, but my main thrust was mostly that there are several places were the CL talks about "e.g. 4k" without ever stating what it is actually using). -- To view, visit https://review.coreboot.org/c/coreboot/+/37262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9 Gerrit-Change-Number: 37262 Gerrit-PatchSet: 11 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 03 Dec 2019 19:20:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org> Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> Gerrit-MessageType: comment