Attention is currently required from: Tim Wawrzynczak, Curtis Chen, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59644 )
Change subject: soc/intel/alderlake: Add TDP to give correct VR configuration. ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59644/comment/999533eb_934bd76c PS1, Line 7: soc/intel/alderlake: Add TDP to give correct VR configuration. Please remove the dot/period at the end [1].
[1]: https://chris.beams.io/posts/git-commit/
https://review.coreboot.org/c/coreboot/+/59644/comment/3a9a5274_20823103 PS1, Line 11: Add TDP to recognize the correct SKU and give the correct power setting. Please add a blank line between paragraphs.
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/59644/comment/78235ea9_ffd1a953 PS1, Line 36: u8 tdp; Please be consistent, so `uint8_t`.
https://review.coreboot.org/c/coreboot/+/59644/comment/9525417f_0c86a47d PS1, Line 83: { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 28, VR_CFG_ALL_DOMAINS_TDC_CURRENT(40, 40) }, That line is new. Maybe make it a separate commit?