5 Mar
2021
5 Mar
'21
10:21 a.m.
Attention is currently required from: Marshall Dawson, Justin Frodsham, Felix Held. Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 )
Change subject: [WIP] vc/amd/fsp/cezanne: add platform_descriptors.c ......................................................................
Patch Set 4:
(1 comment)
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/ddc82554_f5fbf9c2 PS4, Line 57: CLK_GPP_REQ0 = 0x09,
not sure if CLK_GPP_REQ[0..4] exist. i only see CLK_REQ[0.. […]
Yes I cannot see these being used for CZ
--
To view, visit https://review.coreboot.org/c/coreboot/+/51197
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
Gerrit-Change-Number: 51197
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Justin Frodsham justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Justin Frodsham justin.frodsham@amd.corp-partner.google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Justin Frodsham justin.frodsham@protonmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 05 Mar 2021 16:21:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment