7 May
2021
7 May
'21
1:08 p.m.
Attention is currently required from: Felix Held, Piotr Król. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52759 )
Change subject: mb/pcengines/apu2/OemCustomize.c: make AGESA AmdInitPost happy ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/pcengines/apu2/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/52759/comment/28563345_1ee44229 PS1, Line 92: if (get_spd_offset())
my comment was about this call https://review.coreboot. […]
Ahh this one. Yes, true. it shall be fixed to either read SPD from index 0 or 1
--
To view, visit https://review.coreboot.org/c/coreboot/+/52759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I010645f53b404341895d0545855905e81c89165e
Gerrit-Change-Number: 52759
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Piotr Król piotr.krol@3mdeb.com
Gerrit-Comment-Date: Fri, 07 May 2021 11:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment