Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36447 )
Change subject: mainboard/google/hatch: Create helios_diskswap variant
......................................................................
Patch Set 4:
Patch Set 4:
Is anything else needed here?
I'm confused as to why this project (helios_diskwap) needs a whole new coreboot target, when, as far as I can see, it would be just a few patches you could carry in your local tree. Am I missing something?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6536b3908ec569e1ac42ea7c5be85701012ab177
Gerrit-Change-Number: 36447
Gerrit-PatchSet: 4
Gerrit-Owner: Alexis Savery
asavery@chromium.org
Gerrit-Reviewer: Alexis Savery
asavery@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alexis Savery
asavery@google.com
Gerrit-CC: Gwendal Grignou
gwendal@chromium.org
Gerrit-Comment-Date: Mon, 11 Nov 2019 20:14:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment