Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )
Change subject: mediatek/mt8183: Implement the dramc init setting
......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr...
File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr...
PS17, Line 47: 0x2,
does this come from DDR3200? […]
Done
https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr...
PS17, Line 49: u32 sdm_pcw = 0, delta = 0;
no need to initialize them - simply let switch() do that?
Done
https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr...
PS17, Line 76: }
since freq_group is u8, I think we do need a […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I756ad37e78cd1384ee0eb97e5e18c5461d73bc7b
Gerrit-Change-Number: 34988
Gerrit-PatchSet: 19
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Cindy Ching
cindy.ching@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Sep 2019 05:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment