Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )
Change subject: vboot: refactor OPROM code ......................................................................
Patch Set 7:
(2 comments)
Should be ready for commit now.
https://review.coreboot.org/#/c/32262/6/src/security/vboot/misc.h File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/32262/6/src/security/vboot/misc.h@40 PS6, Line 40: uint32_t buffer_size;
Well, this doesn't achieve anything since the compiler just adds 16 byte padding (and in fact we sho […]
Okay, I see what you're saying. So if we make both buffer_offset and buffer_size 16-bit, then they should share the same 32-bit word?
But seems like member alignment depends on the compiler implementation -- how can we be certain that this is the case?
https://review.coreboot.org/#/c/32262/4/src/security/vboot/misc.h File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/32262/4/src/security/vboot/misc.h@40 PS4, Line 40: uint32_t buffer_size;
While we're on the topic -- do you have any thoughts on `struct region` in commonlib/region. […]
OK, thanks for the feedback, Aaron. Let's prevent the tears from flowing and keep `struct selected_region` separate.