Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36700 )
Change subject: sb/intel/i82801gx: Add common LPC decode code ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36700/4/src/mainboard/apple/macbook... File src/mainboard/apple/macbook21/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36700/4/src/mainboard/apple/macbook... PS4, Line 82: register "gen3_dec"
pci_write_config32(PCI_DEV(0, 0x1f, 0), GEN4_DEC, 0x001c0301);
Done
https://review.coreboot.org/c/coreboot/+/36700/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/early_init.c:
https://review.coreboot.org/c/coreboot/+/36700/4/src/southbridge/intel/i8280... PS4, Line 47: if (!config)
that's already checked three lines above
Done