Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31596 )
Change subject: soc/intel/skylake: Unify serial IRQ options
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31596/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31596/2//COMMIT_MSG@20
PS2, Line 20: A lot of Google boards have serial IRQ enabled, while the pin
: seems to be unconnected?
As per BWG section 6. […]
Shouldn't affect this change, though. I'd prefer to change as
little as possible here. Some things had to change, when dt and
Kconfig were contradictory. But that's not the case for the
Google boards. They should be stable across this change and can
be fixed in a follow-up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31596
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79f0cd302e335d8dcf8bf6bc32f3d40ca6713e5c
Gerrit-Change-Number: 31596
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 28 Feb 2019 20:51:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment