Attention is currently required from: Subrata Banik, Matt DeVillier, Tim Wawrzynczak, Paul Menzel, Angel Pons.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 )
Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM
......................................................................
Patch Set 17:
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/b7f4bd8d_c82060f7
PS17, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; }
We really try to avoid having __weak "do-nothing" functions in coreboot, but unless this is implemen […]
Another option is the weak implementation does the single device/dummy entry creation and that gets replaced with the more extensive one on the platform if it exists?
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/ac0054eb_cc2c15d6
PS12, Line 524: if (min_state == UNDEF)
: min_state = D0;
Implemented in Patch set #13. I think the logic is clearer/more correct this way.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63969
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437
Gerrit-Change-Number: 63969
Gerrit-PatchSet: 17
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 03 May 2022 15:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment