[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: move mainboard_silicon_init_params

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44262 )

Change subject: soc/intel/tigerlake: move mainboard_silicon_init_params
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44262/1/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/44262/1/src/soc/intel/tigerlake/fsp... 
PS1, Line 110: mainboard_silicon_init_params(params);
Shouldn't this be done as the very first thing in this function? i.e. on line 95? That will ensure that mainboard can override all configurations at runtime.