Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37551 )
Change subject: amd/hudson: Add PCI ID for FCH SATA Controller (AHCI Mode) for AMD driver. ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37551/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37551/3//COMMIT_MSG@7 PS3, Line 7: amd/hudson: Add PCI ID for FCH SATA Controller (AHCI Mode) for AMD driver. Please remove the dot/period at the end of the git commit message summary.
https://review.coreboot.org/c/coreboot/+/37551/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37551/1/src/include/device/pci_ids.... PS1, Line 451: #define PCI_DEVICE_ID_AMD_CZ_SATA_AHCI_MS 0x7901
"Why MS?" That's how AMD referred to the different IDs in the newer documentation. […]
So Microsoft? I’d prefer AHCI in the code here, and add a comment, that it’s MS in the documentation.