28 Jul
2019
28 Jul
'19
11:32 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: drivers/emulation/qemu: Show splashscreen on bochs VGA ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34599/2/src/drivers/emulation/qemu/... File src/drivers/emulation/qemu/bochs.c:
https://review.coreboot.org/c/coreboot/+/34599/2/src/drivers/emulation/qemu/... PS2, Line 126: if (CONFIG(BOOTSPLASH))
This would require to implement an interface to get the framebuffer parameter in $n places, right?
It's already there: fill_lb_framebuffer() You could add that bootsplash code in edid_fill_fb.c and directly access edid_fb.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34599
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bec06d22423627e8f429c4b47e0dc9920f1464e
Gerrit-Change-Number: 34599
Gerrit-PatchSet: 2
Gerrit-Owner: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Comment-Date: Sun, 28 Jul 2019 09:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mimoja coreboot@mimoja.de
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-MessageType: comment