Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35165 )
Change subject: cpu/intel/car: Skip stack integrity check if FSP_USES_CB_STACK is enable
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35165/1/src/cpu/intel/car/romstage....
File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/35165/1/src/cpu/intel/car/romstage....
PS1, Line 63: if (!CONFIG(FSP_USES_CB_STACK)) {
If we do need to go this route, I think we can make this a little cleaner with some helper functions:
static void setup_stack_guards(uintptr_t base, size_t num_guards);
static void check_stack_guards(uintptr_t base, size_t num_guards);
We can conditionally bail early in those based on the Kconfig once the behavior is properly documented out FSP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I943eff1225b976dc4440a6ca6d02ceea378319f8
Gerrit-Change-Number: 35165
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Aug 2019 18:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment