[coreboot-gerrit] Change in ...coreboot[master]: lib/prog_loaders.c: Add prog_locate_hook() for measured and verified ...

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30811 )

Change subject: lib/prog_loaders.c: Add prog_locate_hook() for measured and verified boot
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/30811/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30811/1//COMMIT_MSG@7 
PS1, Line 7: lib/prog_loaders.c: Add prog_locate_hook() for measured and verified boot.
> Please remove the dot/period at the end.

Done

https://review.coreboot.org/#/c/30811/1//COMMIT_MSG@9 
PS1, Line 9: Before
> Since x86 images are executed in place I'm pretty sure there's no way to avoid TOCTOU there (unless  […]

Implementation verifies image before loading. Don't load images which does not pass verification.

https://review.coreboot.org/#/c/30811/1/src/lib/prog_loaders.c 
File src/lib/prog_loaders.c:

https://review.coreboot.org/#/c/30811/1/src/lib/prog_loaders.c@43 
PS1, Line 43: 	if (prog_locate_hook(prog))
> I don't think this works? prog->rdev is still uninitialized here. […]

This code is working find on our project.