Attention is currently required from: Angel Pons, Elyes Haouas.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69980 )
Change subject: sb/intel: Use "sb/intel/common/tco.h" macros
......................................................................
Patch Set 5: Code-Review-2
(1 comment)
Patchset:
PS5:
https://review.coreboot.org/c/coreboot/+/69760
There was some agreement that {read/write}_pmbaseX() are bad names. They have further problems too -- not having them inlined makes creating useful tracing debug output difficult and increases binary sizes (not much).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8e6d4817ea706fc7058ec15893afb0168c1a2cb
Gerrit-Change-Number: 69980
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 25 Nov 2022 07:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment