Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33661 )
Change subject: vendorcode/google: load sar config from CBFS first then VPD
......................................................................
Patch Set 1:
Patch Set 1:
shouldn't this be some change only merged to specific firmware branches in cros repos?
cbfs first then vpd does not sound like a right/good behavior for upstream globally - people may want to use CBFS as default, then individual project set their VPD to override.
If first project chooses CBFS approach then individual project can just load different SAR file from CBFS by SKU ID (shared the same firmware build target). Loading corresponding VBT by SKU IDs is the similar implementation now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5aa6235fb7a6d0b2ed52893a42f7bd57806af6c1
Gerrit-Change-Number: 33661
Gerrit-PatchSet: 1
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Mon, 24 Jun 2019 07:55:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment