Attention is currently required from: Nico Huber, Nikolai Vyssotski.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49866 )
Change subject: soc/amd: GOP: add UPD for VBIOS buffer
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS13:
Well, we had the same situation with Intel FSP earlier, […]
Just to clear this up a little bit. Sage and Intel both wanted to put the headers in the blobs repo with the binaries for the reasons Nico mentions above. We got a hard -2 when we tried to do it that way.
https://review.coreboot.org/c/coreboot/+/4015/comment/9a41bdd9_88093b34/
The blobs repo then became a "No Code" space.
I'd love to revisit this, but for now, I believe this is the way it needs to be done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49866
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c5d4a9d96e5c3d47e262072b689ed62e59129b3
Gerrit-Change-Number: 49866
Gerrit-PatchSet: 13
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Mar 2021 21:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment