Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kangheui Won, Karthik Ramasubramanian, Felix Held.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59017 )
Change subject: soc/amd/psp_verstage: Reboot on verstage_soc_early_init fail
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/59017/comment/a17d5d55_0c9fdc57
PS1, Line 224:
What will PSP do with a non-zero retval in svc_exit? […]
Agree, doing a vboot_reboot is worth a short.
It seems pretty arbitrary that we are checking for errors on vertage_soc_early_init and not on most of the other calls. I think we should be checking for errors at each step here. I can open a separate bug.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7267a14ab048781b8998d3a6f4220de10e7df250
Gerrit-Change-Number: 59017
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Nov 2021 21:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment