Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29478 )
Change subject: device/i2c_bus: Add i2c_dev_read_at16()
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/29478/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/29478/8//COMMIT_MSG@10
PS8, Line 10: chip (for larger EEPROM parts).
not true (anymore?)
Done
https://review.coreboot.org/c/coreboot/+/29478/8/src/include/device/i2c_bus....
File src/include/device/i2c_bus.h:
https://review.coreboot.org/c/coreboot/+/29478/8/src/include/device/i2c_bus....
PS8, Line 99: uint8_t *buf, size_t len, uint16_t off);
Not sure how it happened, but this signature, the function name and the […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412
Gerrit-Change-Number: 29478
Gerrit-PatchSet: 9
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 19 Sep 2019 14:23:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment