Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44059 )
Change subject: mb/ocp/deltalake: Update SMBIOS type 7 -- Cache Information ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44059/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/44059/3/src/arch/x86/smbios.c@855 PS3, Line 855: t->max_cache_size *= core_count;
As far as I understand only caches that aren't shared between cores can be accumulated here.
Quoted from BIOS writer`s guide: It must multiply the cache size by the number of cores in the physical package divided by the number of cores sharing this cache.
Is this quote same with the thing you mentioned?
https://review.coreboot.org/c/coreboot/+/44059/3/src/arch/x86/smbios.c@984 PS3, Line 984: if (level == 1 && type == SMBIOS_CACHE_TYPE_DATA) {
that's not what CPUID reports. […]
According to BIOS writer`s guide, L1 Data cache size and L1 Instruction cache size should be combined and they are same level cache, so I think they should be combined into a single SMBIOS record for L1 cache with cache type "Unified".