Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42825 )
Change subject: soc/amd/common: Refactor ACPIMMIO posted writes
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42825/4/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42825/4/src/soc/amd/picasso/i2c.c@1...
PS4, Line 166: 0
I would leave this as gpio just for clarity.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42825
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1a5c17c789dd79fea8f348d1a9d32d4301ced88
Gerrit-Change-Number: 42825
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jul 2020 03:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment