Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58211 )
Change subject: soc/intel/common/acpi: drop `RTC_EN` from static wake bits mask ......................................................................
soc/intel/common/acpi: drop `RTC_EN` from static wake bits mask
`RTC_EN` is in the RTC well* so we can rely on the actual register content instead of statically overriding it. Drop it from the static wake bits mask.
* Tested on clevo/l140cu
Change-Id: Ia0ae71f0a472513233bc0fd5625faf15bf86beaf Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/58211 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/soc/intel/common/block/acpi/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index 9bfb91a..4d3cb73 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -218,7 +218,7 @@ * powerbtn or any other wake source like lidopen, key board press etc. */ pm1_en = ps->pm1_en; - pm1_en |= WAK_STS | RTC_EN | PWRBTN_EN; + pm1_en |= WAK_STS | PWRBTN_EN;
pm1_en = acpi_fill_soc_wake(pm1_en, ps);
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.