Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33754 )
Change subject: soc/amd/picasso: Remove all PSP runtime functions ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33754/2/src/soc/amd/picasso/include/soc/pci_... File src/soc/amd/picasso/include/soc/pci_devs.h:
https://review.coreboot.org/#/c/33754/2/src/soc/amd/picasso/include/soc/pci_... PS2, Line 98: : : : : : : Should this be removed? Picasso does have a PSP, what if in the future we need to access it? Sure, device id will be different, but device and function will probably remain the same. This is a header file, it causes no problem to keep the definition, even if not used (would not be the first time something is defined and end up not used).