23 Feb
2021
23 Feb
'21
10:49 a.m.
Attention is currently required from: Martin Roth, Patrick Rudolph, Christian Walter. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44772 )
Change subject: mb/prodrive/hermes/hda_verb: Update verb table for latest board revision ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File src/mainboard/prodrive/hermes/variants/r02/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/comment/c02cf88b_e5bf83f9 PS7, Line 12: AZALIA_PIN_CFG(0, 0x15, 0x02a19c20), /* port A - audio hdr input */
I wonder if we could program these settings statically, and override them for r03+
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/44772
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24ea9149eb2cddb815ff82744a351c926a94aaef
Gerrit-Change-Number: 44772
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Justin van Son justin.van.son@prodrive-technologies.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Comment-Date: Tue, 23 Feb 2021 10:49:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment