[coreboot-gerrit] Change in coreboot[master]: device/oprom: Update vbe_info_t as per vbe specification 3.0

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33806 )

Change subject: device/oprom: Update vbe_info_t as per vbe specification 3.0
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33806/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33806/2//COMMIT_MSG@13 
PS2, Line 13: http://www.vesa.org/public/VBE/vbe3.pdf
> vbe_info_t structure has existing bug, Please refer to comment from Arthur as well.
>
> https://review.coreboot.org/c/coreboot/+/33782/1/src/include/vbe.h#48

Arthur wrote: "If you you memcpy the return value buffer into this
struct, the total_memory value is not correct.". He was referring to
your patch. The existing code does not use memcpy() that way, you did.
The existing code looks fine.
> this structure was not compliant to vbe spec.

Yes, on purpose.
> By approach here to make it proper.

I think it was proper already.
> I can achieve my purpose without changing this code but then i will keep existing bug open where current vbe_info_t structure can't provide correct total_memory value.

There is no existing bug. See above.