[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Handle power resume after power failure

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Martin Roth, Marshall Dawson, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51924 )

Change subject: soc/amd/common: Handle power resume after power failure
......................................................................

Patch Set 2:

(2 comments)

File src/soc/amd/common/block/pm/pmlib.c:

https://review.coreboot.org/c/coreboot/+/51924/comment/656fb33a_10904592 
PS2, Line 21: get_option
> Do we have a cmos_layout.bin? […]

I can defer this i.e. defer using option table until we define the cmos_layout.bin. Anyways we are not using option table from the quick grep. So removing this does not change the flow.

https://review.coreboot.org/c/coreboot/+/51924/comment/d41311dd_f48fcdaf 
PS2, Line 42: PM_RTC_SHADOW_REG
> Writing to these four bits will set the value onto bits [7:4]. Software […]

In the PPR, there is a mention for BIOS to set it to 4 i.e. set bit 2. Also Marshall and Felix commented about the same in the earlier patchsets.