Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37829 )
Change subject: asus/am1i-a: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 2:
(6 comments)
Patch Set 1:
Patch Set 1:
(1 comment)
By the way, it was surprisingly easy to switch away from ROMCC_BOOTBLOCK, and booted fine at the first attempt! I wonder if this approach could be done for the other AMD boards even without testing (if no one could test at the moment).
Yes, I did advertise this as an easy task on the list, after Michal and I completed the first boards for each fam. Mike, you know now what is redundant and what to clean up, go and do the reviews on Elyes work that fixes many of the remaining AGESA boards.
I still see little value dragging along boards without test results but I do not deny you from the chance of +2 reviews on those.
MSI MS7721 is at CB:37737 (merged), Jetway nf81-t56n-lf is at CB:37750. So I'll do it for Gizmo2 CB:37869 and Biostar A68N-5200 CB:37872 - perhaps the last widely available consumer boards from your at-danger-of-removal list ( https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/VUGRM... ). I don't care much for the expensive&rare AMD CRBs, only for these people's boards.
https://review.coreboot.org/c/coreboot/+/37829/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37829/1//COMMIT_MSG@10 PS1, Line 10: a clocks setup
the clock setup
Done.
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/K... File src/mainboard/asus/am1i-a/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/K... PS1, Line 2: bool"AM1I-A"
bool "AM1I-A"
Done.
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 123: pm_write8(0xd2, 0x0);
already in hudson/bootblock. […]
Removed.
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 125: /* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */
I checked https://www.amd.com/system/files/TechDocs/48751_16h_bkdg. […]
Didn't remove yet, need more info.
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 129: pm_write8(0x24, 0x1);
already in hudson/bootblock.c […]
Removed.
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 150: * because of the buffer ICS551M
If we believe the comments we do not need this. […]
Didn't remove yet, need more info.