Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38547 )
Change subject: device: Enumerate device based on IORESOURCE_ASSIGNED
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38547/6/src/device/device.c
File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/38547/6/src/device/device.c@383
PS6, Line 383: /* Skip if IO resource was assigned */
I'm not sure that changing compute_resources() is what we really want. […]
If a device has IO resource assigned which is needed for Xeon-SP processors, it should not be taken into account when calculating the bridge's size/alignment requirements.
https://review.coreboot.org/c/coreboot/+/38547/6/src/device/device.c@498
PS6, Line 498:
I think this is where we'd want to skip pre-assigned resources: […]
I tried your code change. The boot hang at Linuxboot kernel with following message:
NR_IRQS: 8448, nr_irqs: 2360, preallocated irqs: 0
In comparison, with original change, the system boots successfully with corresponding message:
NR_IRQS: 4352, nr_irqs: 1256, preallocated irqs: 16
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69e100ea658fefec905321197b5bd6da1e0e647a
Gerrit-Change-Number: 38547
Gerrit-PatchSet: 9
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jan 2020 22:04:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment