Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45286 )
Change subject: amdfwtool: Clean up the Makefile of amdfwtool
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45286/7/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45286/7/Makefile.inc@a581
PS7, Line 581: -DCONFIG_ROM_SIZE=$(CONFIG_ROM_SIZE)
while it's a good thing to remove this, this still might change behavior. did you check if all platforms pass the rom size to amdfwtool?
it's probably a good idea to remove the CONFIG_ROM_SIZE thing from amdfwtool and error out if no rom size is passed as parameter to initialize .rom_size in the main function
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3688d93de4459f5f838955892086b4b9bf30a9b8
Gerrit-Change-Number: 45286
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dave Frodin
dave.frodin@se-eng.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-CC: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Sep 2020 11:50:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment