Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32694 )
Change subject: vendorcode/google/chromeos: Use explicit zero check in ACPI code
......................................................................
Patch Set 1:
Patch Set 1:
Probably need to do the same for rest of the !X uses:
src/ec/google/wilco/acpi/battery.asl: If (!Local2) {
src/ec/google/wilco/acpi/battery.asl: If (!Local0) {
src/ec/google/wilco/acpi/ec.asl: If (!EREG) {
Yeah I wanted to do some more testing on these as they weren't breaking anything yet like this one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32694
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1688842964f9c2f81ca31073da9c2d71a8c81767
Gerrit-Change-Number: 32694
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 May 2019 15:34:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment