21 Jun
2019
21 Jun
'19
7:17 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33555 )
Change subject: util/cbfstool/fit.c: Bail out when there are not enough FIT entries ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/33555/10/util/cbfstool/fit.c File util/cbfstool/fit.c:
https://review.coreboot.org/#/c/33555/10/util/cbfstool/fit.c@a273 PS10, Line 273:
Somehow, we'd have to keep counting while not adding more entries […]
the ifittool has this check, as I already run into the issue overwriting parts of the bootblock...
--
To view, visit https://review.coreboot.org/c/coreboot/+/33555
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If86678a1eaaa0c5ff571f25bd6bfdb26ac93a946
Gerrit-Change-Number: 33555
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Fri, 21 Jun 2019 07:17:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment