build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38249 )
Change subject: src/mainboard: Port for Chuwi Minibook (m3/8GB) ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38249/1/src/mainboard/chuwi/miniboo... File src/mainboard/chuwi/minibook/romstage.c:
https://review.coreboot.org/c/coreboot/+/38249/1/src/mainboard/chuwi/miniboo... PS1, Line 50: print_spd_info((uint8_t*)mem_cfg->MemorySpdPtr00); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/38249/1/src/mainboard/chuwi/miniboo... File src/mainboard/chuwi/minibook/spd/spd_util.c:
https://review.coreboot.org/c/coreboot/+/38249/1/src/mainboard/chuwi/miniboo... PS1, Line 26: {0x33, 0xCC, 0x00, 0xCC, 0x33, 0xCC, 0x33, 0x00, 0xFF, 0x00, 0xFF, 0x00}}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38249/1/src/mainboard/chuwi/miniboo... PS1, Line 35: {3, 1, 6, 4, 2, 0, 5, 7}}; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38249/1/src/mainboard/chuwi/miniboo... PS1, Line 35: {3, 1, 6, 4, 2, 0, 5, 7}}; space required after that close brace '}'