Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu.
Hello Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81349?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: soc/intel/xeon_sp: Remove PAM lock and unlock operations ......................................................................
soc/intel/xeon_sp: Remove PAM lock and unlock operations
unlock_pam_regions routes Programmable Attribute Map (PAM) access to DRAM. lock_pam0123 locks the setting before leaving coreboot. In some SoCs, the FSP will by-default apply such settings and hence bootloader setting is not needed.
Move unlock_pam_regions and lock_pam0123 from common boot steps to SoC specific boot steps.
TEST=intel/archercity CRB
Change-Id: I3fd1d806807449e6a4d9d4d2c8a47ce61ed53018 Signed-off-by: Shuo Liu shuo.liu@intel.com --- M src/soc/intel/xeon_sp/cpx/Makefile.mk M src/soc/intel/xeon_sp/cpx/chip.c A src/soc/intel/xeon_sp/cpx/finalize.c M src/soc/intel/xeon_sp/finalize.c M src/soc/intel/xeon_sp/include/soc/util.h M src/soc/intel/xeon_sp/romstage.c M src/soc/intel/xeon_sp/skx/Makefile.mk M src/soc/intel/xeon_sp/skx/chip.c A src/soc/intel/xeon_sp/skx/finalize.c M src/soc/intel/xeon_sp/util.c 10 files changed, 93 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/81349/10