Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35126 )
Change subject: soc/intel: Add Cascade Lake SP support
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35126/3/src/soc/intel/skylake/bootb...
File src/soc/intel/skylake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/35126/3/src/soc/intel/skylake/bootb...
PS3, Line 63: Sky Lake-E
I would remove the space, so as to align with the other names: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If351d554db62c51849ff6c7bb49074e587f14e6d
Gerrit-Change-Number: 35126
Gerrit-PatchSet: 4
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Sep 2019 15:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment