Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44704 )
Change subject: soc/mediatek/mt8192: Do dramc software impedance calibration ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... PS1, Line 3: string
I think we usually want to add header files when adding the code that really uses it. […]
Please remove it.
https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... PS1, Line 6: timer.h>
I think we usually want to add header files when adding the code that really uses it. […]
Please remove it.
https://review.coreboot.org/c/coreboot/+/44704/2/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44704/2/src/soc/mediatek/mt8192/dra... PS2, Line 44: switch (drv_type) {
This can be simplified by […]
Done
https://review.coreboot.org/c/coreboot/+/44704/2/src/soc/mediatek/mt8192/dra... PS2, Line 91: chn
Add 'const' for it.
Done
https://review.coreboot.org/c/coreboot/+/44704/2/src/soc/mediatek/mt8192/dra... PS2, Line 92: cal_res
No need to initialize it.
Done