Hello Andrew McRae, Edward O'Callaghan, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35605
to look at the new patch set (#7).
Change subject: util/mb/google/hatch: fix style issues in shell script ......................................................................
util/mb/google/hatch: fix style issues in shell script
* Use all caps for variables. * Use a single exit code for failures. * No need to popd before exiting the script. * Do ${var,,} and ${var^^} into variables instead of using it everywhere. * Add more punctuation in comments.
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: I63aa0aa633f36b9543e809fc42fac955da5960a3 --- M util/mainboard/google/hatch/create_coreboot_variant.sh 1 file changed, 24 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/35605/7