[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/cmn: Include ME specification configuration at common

[Subrata Banik (Code Review)]

Attention is currently required from: Felix Singer, Tarun Tuli, Dinesh Gehlot, Kapil Porwal, Maximilian Brune, Angel Pons, Arthur Heymans, Werner Zeh.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73128 )

Change subject: soc/intel/cmn: Include ME specification configuration at common
......................................................................

Patch Set 1:

(2 comments)

File src/soc/intel/common/block/cse/Kconfig:

https://review.coreboot.org/c/coreboot/+/73128/comment/13d23a5e_c55c62e1 
PS1, Line 259: if SOC_INTEL_CSE_HAVE_SPEC_SUPPORT
> Put this line above SOC_INTEL_COMMON_BLOCK_ME_SPEC_11. Than you can also remove the depends of all SOC_INTEL_COMMON_BLOCK_ME_SPEC_x

how about below change, then u don;t need to select two kconfig from each soc?

```
config SOC_INTEL_COMMON_BLOCK_ME_SPEC_18
    bool
        select SOC_INTEL_CSE_HAVE_SPEC_SUPPORT
    help
      This config will enable 'ME specification version 18'. It will ensure ME specific
      declaration and uses of required data structures for Host firmware 
      status registers
```

https://review.coreboot.org/c/coreboot/+/73128/comment/cf245423_222bcbf2 
PS1, Line 261: config ME_SPEC_11
> That's what I mean. Can't you just write CONFIG_ME_SPEC == 11 instead of CONFIG_ME_SPEC == CONFIG_ME_SPEC_11?

ideally we avoid hardcoding and use macro