Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/28735 )
Change subject: siemens/mc_apl1: Add new mainboard variant mc_apl2 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/28735/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28735/1//COMMIT_MSG@10 PS1, Line 10: contains
"contains" or "is based on"
Done
https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig:
https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 8: select DRIVER_SIEMENS_NC_F
We do not need the IO based UART here. […]
Done
https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c:
https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 32: /* Set Master Enable for on-board PCI device. */ : dev = dev_find_device(PCI_VENDO
This is not needed as well but we can get rid of it in one of the next commits.
You're right. We should go the same way as with the baseboard.