Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62008 )
Change subject: drivers/intel/i210: Set log level to BIOS_NOTICE on missing MAC address ......................................................................
drivers/intel/i210: Set log level to BIOS_NOTICE on missing MAC address
Set the log level to BIOS_NOTICE for the case where the mainboard can not provide a MAC address since this can be a valid case. Showing this message with log level BIOS_ERR is not appropriate.
In addition, rephrase the message to make clear that if the mainboard does not provide a MAC address the one stored in the MAC will be used.
Change-Id: Ibfc58845f0ea47ced048b446e685c4860a29f075 Signed-off-by: Werner Zeh werner.zeh@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/62008 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/drivers/intel/i210/i210.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Mario Scheithauer: Looks good to me, approved
diff --git a/src/drivers/intel/i210/i210.c b/src/drivers/intel/i210/i210.c index 0b2fcd2..c63ae0e 100644 --- a/src/drivers/intel/i210/i210.c +++ b/src/drivers/intel/i210/i210.c @@ -187,7 +187,7 @@ /*Check first whether there is a valid MAC address available */ status = mainboard_get_mac_address(dev, adr_to_set); if (status != CB_SUCCESS) { - printk(BIOS_ERR, "I210: No valid MAC address found\n"); + printk(BIOS_NOTICE, "I210: Mainboard has no address, keep the one in MAC.\n"); return; } /* Before we will write a new address, check the existing one */