Attention is currently required from: Hung-Te Lin, Jakub Czapiga, Arthur Heymans, Yu-Ping Wu, Jianjun Wang.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63494 )
Change subject: coreboot_tables: Replace 'struct lb_uint64' with lb_uint64_t
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
Patchset:
PS5:
We could, but due to licensing issue, we can't just copy the comment to the bsd header file. […]
I think we absolutely should combine those two files under commonlib/bsd (now that we can, thanks to Jakub's recent work), to eliminate the constant duplication between them. To steer clear of licensing issues that should be done by taking the libpayload file as basis -- for stuff like comments that we want to preserve, just rewrite them in your own words or something (everything else should already be the same anyway).
I don't want to force you to do that as part of this patch though, since it's getting pretty far away from what you came here to do. It would be good if someone could find the time to do that eventually, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6b037e4403a8000625f4a5fb8d20311fe76200a
Gerrit-Change-Number: 63494
Gerrit-PatchSet: 8
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 20:29:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-MessageType: comment